Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: github: Cleanup PR template #9472

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 12, 2022

Related Issues

I'm opening quite a lot of PRs so I see it a lot and have some observations.

Proposed Changes

  • Avoid line wraps in the 'write' mode
  • Don't be as verbose with checklist areas
  • Don't use _ in the checklist
  • Drop a ( ) prefix in the PR title example
  • Make the first one/two words of each checklist item relay what the item is for

Additional Info

Before:
2022-10-12-103729_845x823_scrot

After:
2022-10-12-103718_839x827_scrot

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner October 12, 2022 08:38
@geoff-vball geoff-vball requested a review from jennijuju October 12, 2022 15:11
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are in fact opening PRs.

@arajasek arajasek merged commit 983fd20 into master Oct 12, 2022
@arajasek arajasek deleted the misc/gh-pr-templ-cleanup branch October 12, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants