Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add invariance checks to v17 migration test #9454

Merged
merged 10 commits into from
Oct 13, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Oct 7, 2022

Related Issues

Implements part of #9246

Proposed Changes

Tests the following invariants for the v17 migration:

  • that for each pending, verified deal in v8 market, there is a corresponding allocation in v9 verifreg Allocations
  • that nextAllocationID is equal to the number of pending, verified deals in v8 market
  • that for each pending, verified deal in v8 market, there is a corresponding entry in v9 market PendingDealAllocationIds
  • that all miners that have PreCommits with deals in them have non-nil UnsealedCid, and this CID is correctly calculated:

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner October 7, 2022 21:14
@geoff-vball geoff-vball force-pushed the gstuart/migration-test branch 3 times, most recently from 365d6d7 to 1579188 Compare October 11, 2022 19:24
@geoff-vball geoff-vball changed the title test: Add check to v17 migration test test: Add invariance checks to v17 migration test Oct 12, 2022
Base automatically changed from gstuart/verifreg-accessors to release/v1.18.0 October 12, 2022 17:09
@geoff-vball geoff-vball force-pushed the gstuart/migration-test branch from 1579188 to 339c598 Compare October 12, 2022 19:55
@arajasek arajasek force-pushed the gstuart/migration-test branch from 339c598 to 9c72d1b Compare October 13, 2022 15:08
@arajasek arajasek force-pushed the gstuart/migration-test branch from d2ecb74 to 86913ad Compare October 13, 2022 19:30
cmd/lotus-shed/migrations.go Outdated Show resolved Hide resolved
cmd/lotus-shed/migrations.go Outdated Show resolved Hide resolved
cmd/lotus-shed/migrations.go Outdated Show resolved Hide resolved
@arajasek arajasek merged commit 8755c98 into release/v1.18.0 Oct 13, 2022
@arajasek arajasek deleted the gstuart/migration-test branch October 13, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants