fix: ux: Add outputs to wallet commands #9416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding command outputs to `lotus wallet set-default` and `lotus wallet delete`
geoff-vball
approved these changes
Oct 5, 2022
magik6k
reviewed
Oct 5, 2022
| @@ -260,6 +260,7 @@ var walletSetDefault = &cli.Command{ | |||
| return err | |||
| } | |||
|
|
|||
| fmt.Println("Default address set to:", addr) | |||
There was a problem hiding this comment.
Don't we want to have a space here?
Suggested change
| fmt.Println("Default address set to:", addr) | |
| fmt.Println("Default address set to: ", addr) |
There was a problem hiding this comment.
I originally had a space there, but during testing I got double spaces in the output, which was a bit surprising. This is what I currently get with no space:
phi:~$lotus wallet set-default t1lu7zszqwr7emsvjznr7utbsmsjia376focp2gvq
Default address set to: t1lu7zszqwr7emsvjznr7utbsmsjia376focp2gvq
arajasek
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding command outputs to
lotus wallet set-defaultandlotus wallet deleteProposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps