feat: sealing pipeline: Prepare deal assigning logic for FIP-45 #9412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b055380 to
69b6d7f
Compare
magik6k
commented
Oct 4, 2022
magik6k
commented
Oct 4, 2022
8c8b860 to
b5e9f27
Compare
Base automatically changed from
gstuart/integrate-verifreg-changes-fip45
to
release/v1.18.0
October 7, 2022 15:27
69b6d7f to
75539ac
Compare
ZenGround0
reviewed
Oct 7, 2022
magik6k
commented
Oct 10, 2022
ZenGround0
approved these changes
Oct 10, 2022
| @@ -127,7 +127,7 @@ type State interface { | |||
| ) (weight, verifiedWeight abi.DealWeight, err error) | |||
| NextID() (abi.DealID, error) | |||
| GetState() interface{} | |||
| GetAllocationIdForPendingDeal(dealId abi.DealID) (verifregtypes.AllocationId, error) | |||
| GetAllocationIdForPendingDeal(dealId abi.DealID) (*verifregtypes.AllocationId, error) | |||
There was a problem hiding this comment.
Instead of using nil you shoulld use the zero value which stands for invalid allocation. Updated go-state-types to help out: filecoin-project/go-state-types#93
|
FYI @jennijuju this is the kind of thing we definitely want an integration test for after code freeze |
noted! ideally we shall have an integration test WITH the pr.. (but given we are cut close to the ddl I will create an follow up issue! thanks for the ping. |
ZenGround0
approved these changes
Oct 11, 2022
zl03jsj
reviewed
Oct 12, 2022
storage/pipeline/input.go
Outdated
| for _, piece := range sector.Pieces { | ||
| used += piece.Piece.Size.Unpadded() | ||
|
|
||
| if piece.DealInfo.DealProposal.EndEpoch > lastDealEnd { |
There was a problem hiding this comment.
Because piece.DealInfo is a pointer, should check if it is nil first?
There was a problem hiding this comment.
Thank you for the review!
6e36386 to
65e37c2
Compare
arajasek
approved these changes
Oct 12, 2022
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #9276
What this does