Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade hid #9406

Merged
merged 2 commits into from
Oct 4, 2022
Merged

chore: Upgrade hid #9406

merged 2 commits into from
Oct 4, 2022

Conversation

ianconsolata
Copy link
Contributor

Related Issues

Zondax/hid#4
#7597

Proposed Changes

It's been awhile since this was fixed upstream, and the Zondax folks haven't cut a new release yet. So instead just go get github.com/zondax/hid@5552068 and use a SHA specified version that includes the change.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

This issue has been fixed in the upstream repository for months, but no
release has been issued despite repeated requests. So instead just rely
on the specific commit hash until a release is cut.
@ianconsolata ianconsolata requested a review from a team as a code owner October 3, 2022 13:00
@magik6k magik6k changed the title _chore_: Upgrade hid chore: Upgrade hid Oct 4, 2022
@magik6k magik6k merged commit e6c8de6 into master Oct 4, 2022
@magik6k magik6k deleted the upgrade-hid branch October 4, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants