Eth JSON-RPC API: implement eth_getCode and eth_getStorageAt #9397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes with a temporary hack. The EVM runtime actor uses the U256 parameter type in GetStorageAtParams, which serializes as a hex-encoded string. It should serialize as bytes. We didn't get to fix in time for Iron, so for now we just pass through the hex-encoded value passed through the Eth JSON-RPC API, by remarshalling it. We don't fix this at origin (builtin-actors) because we are not updating the bundle for Iron.
ychiaoli18
reviewed
Sep 29, 2022
1 task
adlrocha
referenced
this pull request
in consensus-shipyard/lotus
Oct 13, 2022
adlrocha
referenced
this pull request
in consensus-shipyard/lotus
Oct 13, 2022
vyzo
pushed a commit
that referenced
this pull request
Nov 9, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth_getStorageAt comes with a major hack for now because of a serde snafu in the EVM runtime in builtin-actors. We are not updating the bundle for Iron, so we patch it here. The type we used in the EVM runtime for the storage slot serializes to a hex-encoded int instead of to purely an big-endian array of bytes. We'll fix this at origin in builtin-actors.
Another caveat is that retrieving a storage key that doesn't exist returns an error. Instead, it should return a 0x0.