Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: miner paramfetch: Don't fetch param files when not needed #9391

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 29, 2022

Proposed Changes

On lotus-miner nodes with disabled local PoSt / C2 / PR2 no snarks are ever computed, which means that we don't need .param files for anything. This makes node startup much faster, reducing downtime by a lot when restarts are needed.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner September 29, 2022 12:10
@magik6k
Copy link
Contributor Author

magik6k commented Sep 29, 2022

(verified on my setup)

@magik6k magik6k merged commit 88a1701 into master Sep 29, 2022
@magik6k magik6k deleted the feat/noparam-miner branch September 29, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants