Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ci_: Use golang 1.18.1 to build appimage #9386

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

ianconsolata
Copy link
Contributor

@ianconsolata ianconsolata commented Sep 27, 2022

Related Issues

Updating golang to 1.18.1 broke the AppImage build: https://app.circleci.com/pipelines/github/filecoin-project/lotus/23339/workflows/0d8285e1-5977-4b8e-aa25-45d55ac61ac3/jobs/600644

It seems we were relying on an implicitly installed go version in the underlying ubuntu-2004 machine image. This should be backported to the 1.17.2 release branch , or else it will not include an AppImage release artifact.

Proposed Changes

This explicitly downloads and installs a specific golang version (in this case, 1.18.1) onto the machine image before running the app image builder. This should allow us to easily update the version in the future, and will hopefully make it clear when upgrading the go version that the app image builder needs to be updated too.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k merged commit 7bf24cc into master Sep 28, 2022
@magik6k magik6k deleted the fix-appimage-go-version branch September 28, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants