_ci_: Use golang 1.18.1 to build appimage #9386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Updating golang to 1.18.1 broke the AppImage build: https://app.circleci.com/pipelines/github/filecoin-project/lotus/23339/workflows/0d8285e1-5977-4b8e-aa25-45d55ac61ac3/jobs/600644
It seems we were relying on an implicitly installed go version in the underlying ubuntu-2004 machine image. This should be backported to the 1.17.2 release branch , or else it will not include an AppImage release artifact.
Proposed Changes
This explicitly downloads and installs a specific golang version (in this case, 1.18.1) onto the machine image before running the app image builder. This should allow us to easily update the version in the future, and will hopefully make it clear when upgrading the go version that the app image builder needs to be updated too.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps