Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build: set PropagationDelaySecs correctly #9358

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Sep 22, 2022

Related Issues

The global field wasn't actually being set (just a local variable).

Proposed Changes

Set the field correctly.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner September 22, 2022 15:43
@Reiers
Copy link

Reiers commented Sep 22, 2022

export PROPAGATION_DELAY_SECS=8

2022-09-22T18:12:08.043+0200	INFO	miner	miner/miner.go:475	completed mineOne	{"tookMilliseconds": 14, "forRound": 1326745, "baseEpoch": 1326744, "baseDeltaSeconds": 8, "nullRounds": 0, "lateStart": false, "beaconEpoch": 0, "lookbackEpochs": 900, "networkPowerAtLookback": "3587328484311040", "minerPowerAtLookback": "0", "isEligible": false, "isWinner": false, "error": null}

export PROPAGATION_DELAY_SECS=12

2022-09-22T18:15:12.478+0200	INFO	miner	miner/miner.go:475	completed mineOne	{"tookMilliseconds": 3, "forRound": 1326751, "baseEpoch": 1326750, "baseDeltaSeconds": 12, "nullRounds": 0, "lateStart": false, "beaconEpoch": 0, "lookbackEpochs": 900, "networkPowerAtLookback": "3587328484311040", "minerPowerAtLookback": "0", "isEligible": false, "isWinner": false, "error": null}

@arajasek
Copy link
Contributor Author

Dealing with the flaky test failure in #9061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants