Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: actors: Integrate builtin-actors changes for FIP-0045 #9355

Merged
merged 30 commits into from
Oct 7, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Sep 21, 2022

Related Issues

resolves #9274, #9275

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner September 21, 2022 21:51
@geoff-vball geoff-vball force-pushed the gstuart/integrate-verifreg-changes-fip45 branch from 87371d5 to dc20122 Compare September 21, 2022 21:57
@geoff-vball geoff-vball changed the base branch from master to release/v1.18.0 September 21, 2022 21:57
@geoff-vball geoff-vball force-pushed the gstuart/integrate-verifreg-changes-fip45 branch 6 times, most recently from 6319515 to 2c31944 Compare September 22, 2022 18:38
@geoff-vball geoff-vball changed the title feat: actors: Integrate verifreg changes for FIP-0045 feat: actors: Integrate builtin-actors changes for FIP-0045 Sep 22, 2022
@geoff-vball geoff-vball force-pushed the gstuart/integrate-verifreg-changes-fip45 branch 20 times, most recently from 3f94a1e to f4584c5 Compare September 27, 2022 17:23
@geoff-vball geoff-vball force-pushed the gstuart/integrate-verifreg-changes-fip45 branch from 8c8b860 to b5e9f27 Compare October 6, 2022 15:06
chain/actors/builtin/datacap/util.go Outdated Show resolved Hide resolved
}
var dcap abi.StoragePower
return vh.ForEach(&dcap, func(key string) error {
a, err := address.NewFromBytes([]byte(key))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right -- the map is keyed by IdAddrKey, so you're gonna need to go string -> bytes -> uint64 -> Address. Something like

id, n, err := varint.FromUvarint([]byte(key))
		if n != len([]byte(key)) {
			// freak out
		}

		a, err := address.NewIDAddress(id)

Copy link
Contributor Author

@geoff-vball geoff-vball Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, though I thing the check on the length of read bytes is overkill.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you could drop that if you wanted.

@arajasek arajasek merged commit 6e99a6b into release/v1.18.0 Oct 7, 2022
@arajasek arajasek deleted the gstuart/integrate-verifreg-changes-fip45 branch October 7, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update filplus list-clients update StateVerifiedClientStatus w/ token contract
3 participants