-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: actors: Integrate builtin-actors changes for FIP-0045 #9355
feat: actors: Integrate builtin-actors changes for FIP-0045 #9355
Conversation
87371d5
to
dc20122
Compare
6319515
to
2c31944
Compare
3f94a1e
to
f4584c5
Compare
8c8b860
to
b5e9f27
Compare
…variants Check datacaps for v8 verifreg match v9 datacap actor
chain/actors/builtin/datacap/util.go
Outdated
} | ||
var dcap abi.StoragePower | ||
return vh.ForEach(&dcap, func(key string) error { | ||
a, err := address.NewFromBytes([]byte(key)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't right -- the map is keyed by IdAddrKey, so you're gonna need to go string -> bytes -> uint64 -> Address. Something like
id, n, err := varint.FromUvarint([]byte(key))
if n != len([]byte(key)) {
// freak out
}
a, err := address.NewIDAddress(id)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, though I thing the check on the length of read bytes is overkill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you could drop that if you wanted.
Related Issues
resolves #9274, #9275
Proposed Changes
builtin-actors
[v9.0.0-rc.2](https://github.com/filecoin-project/builtin-actors/releases/tag/v9.0.0-rc.2)
go-state-types
datacap
actorGetAllocationId
tomarket
actor interfaceGetAllocation
toverifreg
actor interfacedatacap
now point to thedatacap
actor instead ofverifreg
for v9 and afterlotus-shed verifreg list-clients
as this has been moved tofilplus
go-fil-markets
v1.24.1-rc1
(updates market actor to v9)StateGetDealAllocation
andStateGetAllocation
for getting allocation info from the verifreg actorTestGetAllocationFromDealId
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps