Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrievals: price-per-byte calculation fix #9353

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Someone opened a PR with this fix here. They were unresponsive to the code change so just filing it here.

Proposed Changes

Total price includes unseal price, so when unseal price is non-zero this calculation for price-per-byte will be wrong.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner September 21, 2022 19:34
@geoff-vball geoff-vball force-pushed the gstuart/retrieval-calculation-fix branch from 58dcac5 to 3eb3936 Compare September 21, 2022 19:35
@geoff-vball geoff-vball force-pushed the gstuart/retrieval-calculation-fix branch from 3eb3936 to a1e08e5 Compare September 21, 2022 19:35
@arajasek arajasek merged commit 24c536f into master Sep 21, 2022
@arajasek arajasek deleted the gstuart/retrieval-calculation-fix branch September 21, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants