Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ffiwrapper: Close readers in AddPiece #9328

Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix: ffiwrapper: Close readers in AddPiece #9328

merged 1 commit into from
Sep 19, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 19, 2022

Related Issues

Closes #9263
Might fix #9327

Proposed Changes

Close readers in AddPiece

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • [x[ The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • CI is green

@magik6k magik6k requested a review from a team as a code owner September 19, 2022 07:51
@magik6k magik6k force-pushed the fix/ffiwrap-close-ap branch from b11b563 to fde2b94 Compare September 19, 2022 07:52
@magik6k magik6k force-pushed the fix/ffiwrap-close-ap branch from fde2b94 to d68bb93 Compare September 19, 2022 07:53
@marshyonline
Copy link

@magik6k - One this is good to go, how best should i test it?

@magik6k
Copy link
Contributor Author

magik6k commented Sep 19, 2022

I'd just see if the behavior described in #9327 keeps occurring

@magik6k magik6k merged commit 39af6e0 into master Sep 19, 2022
@magik6k magik6k deleted the fix/ffiwrap-close-ap branch September 19, 2022 15:47
@Fatman13 Fatman13 mentioned this pull request Sep 30, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoff-vball geoff-vball geoff-vball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connections do not close when using Boost Make sure that readers are closed in AddPiece
3 participants
@magik6k @marshyonline @geoff-vball