Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: Abort upgrades in sectors with no deals #9310

Merged
merged 4 commits into from
Sep 17, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 14, 2022

Related Issues

Fixes #8686 (will need some testing)

Proposed Changes

  • Auto-abort upgrading sectors which didn't get any deals assigned
  • In calcTargetExpiration, don't pick the lowest possible deal duration as minExpiration when there isn't an entire sector worth of deals in the input queue - use the expiration from lowest-expiration deal in the queue (note that in this case the target expiration will be max deal duration, so we'll still try to find sectors with longer expiration in that case; but in case there are no better upgradable sectors we could pick one with way too low expiration to be useful)
  • Add 2 config fields to configure minimums for minimumExpiration and targetExpiration

Additional Info

When testing it will be really useful to see debug logs from the sectors subsystem - lotus-miner log set-level --system sectors debug

@magik6k magik6k requested a review from a team as a code owner September 14, 2022 10:55
Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fixes. Let's pass off to the TSEs for some testing

@jennijuju jennijuju merged commit 4abc38d into master Sep 17, 2022
@jennijuju jennijuju deleted the fix/empty-snap branch September 17, 2022 01:21
@jennijuju
Copy link
Member

@filecoin-project/lotus-tse plz test this with current master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants