Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api/cli: change beneficiary propose and confirm for actors and multisigs. #9307

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Closes #9254 and #9253

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner September 14, 2022 04:45
@geoff-vball
Copy link
Contributor Author

@arajasek This is generally ready for review, but something in the storage miner API seems to have broken a bunch of tests. Was this the kind of thing we have to go into docgen.go for?

@geoff-vball geoff-vball force-pushed the gstuart/change-beneficiary branch from 0945e94 to d916f92 Compare September 14, 2022 17:37
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes (a lot of the comments left on the first command apply to the subsequent commands too, so please apply those changes across all 4 commands).

cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Show resolved Hide resolved
@geoff-vball geoff-vball force-pushed the gstuart/change-beneficiary branch from c86e468 to 9e2fe56 Compare September 14, 2022 20:12
@geoff-vball geoff-vball force-pushed the gstuart/change-beneficiary branch from 9e2fe56 to 84fd51f Compare September 14, 2022 20:52
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, but g2g once they're addressed

cmd/lotus-miner/actor.go Show resolved Hide resolved
cmd/lotus-miner/actor.go Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
@arajasek arajasek disabled auto-merge September 14, 2022 21:47
@arajasek arajasek merged commit 305589e into master Sep 14, 2022
@arajasek arajasek deleted the gstuart/change-beneficiary branch September 14, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a cli for ChangeBeneficiary
2 participants