Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api: Ignore uuid check for messages with uuid not set #9303

Conversation

shrenujbansal
Copy link
Contributor

@shrenujbansal shrenujbansal commented Sep 13, 2022

Related Issues

#9299

Proposed Changes

Enhances the existing uuid to check to also check for non nil spec but with MsgUuid not set

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@shrenujbansal shrenujbansal requested a review from a team as a code owner September 13, 2022 20:36
@shrenujbansal shrenujbansal linked an issue Sep 13, 2022 that may be closed by this pull request
18 tasks
@shrenujbansal shrenujbansal changed the title Ignore uuid check for messages with uuid not set fix: api: Ignore uuid check for messages with uuid not set Sep 13, 2022
@magik6k magik6k merged commit bdb62e6 into master Sep 14, 2022
@magik6k magik6k deleted the 9299-messages-with-empty-uuids-to-mpoolpushmessage-will-be-rejected branch September 14, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages with empty UUIDs to MpoolPushMessage will be rejected
2 participants