Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] sector import c1/pc1 out types #9300

Closed
wants to merge 26 commits into from
Closed

[wip] sector import c1/pc1 out types #9300

wants to merge 26 commits into from

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 13, 2022

Related Issues

On top of #9210

Proposed Changes

This PR adds Go types to Commit1/PreCommit1 "output". Previously those were treated as opaque byte blobs, but for the SaaS effort we'll need to have more precise definition for those types - both to get better self-documenting interfaces, and to be able to implement more robust checks for the ReceiveSector APIs.

Additional Info

Types in storage/sealer/storiface/types_proofs.go

The PR is a bit broken right now because there are some issues with mixing cbor-gen and generics.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k force-pushed the feat/recievesector branch 3 times, most recently from 495bc4a to efc1332 Compare September 14, 2022 09:22
@magik6k magik6k force-pushed the feat/recievesector branch 3 times, most recently from c8de9d4 to 859c260 Compare September 19, 2022 10:13
Base automatically changed from feat/recievesector to master September 19, 2022 11:04
@magik6k magik6k closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant