feat: api/cli: beneficiary withdraw api and cli

[geoff-vball]

Related Issues

Closes #9257 and #9258

Proposed Changes

Adds an api call and cli command to withdraw funds from a miner as the beneficiary.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

• All commits have a clear commit message.
• The PR title is in the form of of <PR type>: <area>: <change being made>
  • example: fix: mempool: Introduce a cache for valid signatures
  • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
  • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
• This PR has tests for new functionality or change in behaviour
• If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
• CI is green

[arajasek]

I don't think we want the new API method in the FullNodeAPI here, just the Storage API. See ActorWithdrawBalance for an equivalent method to use as a blueprint.

[geoff-vball]

@arajasek Does the storage API get run on the lotus node or through lotus-miner? I think I feel pretty strongly that this is an action that shouldn't require running lotus-miner to achieve.

[arajasek]

@geoff-vball Yes, api_storage is lotus-miner only. I would match what we currently have for (Owner)WithdrawBalance for now (which is to only have it on the miner API), and create a ticket to support both (Owner)WithdrawBalance and BeneficiaryWithdrawBalance over the node API. I'd be...skeptical about whether these are actions we want to be able to take remotely over an API, but we can descope that discussion.

Additionally, I would move the CLI commands to the following two locations, you can match existing behaviour there:

lotus/cmd/lotus-shed/actor.go

Line 39 in e65fae2

var actorWithdrawCmd = &cli.Command{

,

lotus/cmd/lotus-miner/actor.go

Line 233 in 15ea395

var actorWithdrawCmd = &cli.Command{

. The first can be called by anyone who has built lotus-shed, the second requires the miner running in the background.

TL;DR: let's match what we have for the existing withdrawBalance method and take it from there.

[arajasek]

Can we rename this to ownerWithdrawCmd, rename the command itself to owner-withdraw, but leave withdraw as an alias?

[geoff-vball]

Refactored everything. Now the cli commands just need a flag to know to send from beneficiary.