Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli: Add option to terminate sectors from worker address #9291

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Sep 12, 2022

Related Issues

Closes #8664

Proposed Changes

Adds a flag to allow either owner address or worker address to send terminate sectors message.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner September 12, 2022 14:57
@arajasek
Copy link
Contributor

Was this change motivated by someone wanting it?

Regardless, I think this would still be incomplete, because you can also use control addresses to send this message. I'd suggest just changing it to an optional from flag, and using that address if set. If unset, I'd probably default to using the worker.

@geoff-vball geoff-vball force-pushed the gstuart/terminate-from-worker-addr branch from 394f9e3 to 30439ad Compare September 13, 2022 14:13
@geoff-vball geoff-vball force-pushed the gstuart/terminate-from-worker-addr branch from 30439ad to a0ec3a7 Compare September 13, 2022 14:14
@geoff-vball
Copy link
Contributor Author

@arajasek added the related ticket. What's a control address? Changes have been made

@arajasek
Copy link
Contributor

@geoff-vball "Control addresses" are a set of addresses that can control a miner. They are significantly less powerful than the owner, and have a similar privilege level to the worker with some key differences:

  • you can have a set of control addresses, but only one worker
  • they can be either secp or bls (and maybe even, like, multisigs), while the worker must be BLS
  • only the worker can sign block headers.

The idea is just to have more than one address that can do things like submit posts, seal sectors, etc...so if one key is inaccessible / out of funds, a fallback control address can Do the Thing.

See the miner actor source code for more.

@arajasek arajasek merged commit 7b23814 into master Sep 14, 2022
@arajasek arajasek deleted the gstuart/terminate-from-worker-addr branch September 14, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus-shed terminate sectors fails with Multisig Owner
2 participants