Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: env: propagation delay #9290

Merged
merged 2 commits into from
Sep 20, 2022
Merged

feat: env: propagation delay #9290

merged 2 commits into from
Sep 20, 2022

Conversation

jennijuju
Copy link
Member

Related Issues

Proposed Changes

  • add an env var for setting propagation delay
  • increasing the default delay from 6 to 10 sec (base on Storage Provider Block Mining Metrics #8891 the computation is faster and should be safe to wait longer for parent blocks)

Additional Info

@filecoin-project/lotus-tse should test the new default out

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju jennijuju requested a review from a team as a code owner September 12, 2022 14:51
@arajasek arajasek merged commit b6d3643 into master Sep 20, 2022
@arajasek arajasek deleted the jen/propgation branch September 20, 2022 02:00
@beck-8
Copy link
Contributor

beck-8 commented Sep 25, 2022

It would be better to add command-line controls.

Because of the use of environmental variables, each adjustment needs to be restarted, which will lead to increased risk and is not conducive to finding the right value.

In addition, the upper limit and lower limit check should be added to prevent the setting of incorrect values.

@jennijuju @arajasek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants