Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: network: add nv17 and integrate the corresponding go state type #9267

Merged
merged 9 commits into from
Sep 12, 2022

Conversation

jennijuju
Copy link
Member

@jennijuju jennijuju commented Sep 5, 2022

Related Issues

Towards #9246, #9248, #9249

Proposed Changes

  • Upgrades go-state-types to include v9 types and migration
  • Adds network version 17 and the upgrade height
  • Adds the v17 migration
  • Updates to FVM release/v2 (through FFI)
  • Adds the v9 actors bundles (using https://github.com/filecoin-project/builtin-actors/releases/tag/dev%2F20220907-v9 for now)
  • Refactors the Actor Registry creation process
    • This is something we cut from scope in v16 by instead using the v8 specs-actors, and monkey-patching the synthetic -> real CIDs
    • With this PR, we get the method signatures from go-state-types (see Feat: add methods.go files for all builtin-actors go-state-types#66)
    • We use that information to create new RegistryEntrys that satisfy the same interface
    • There is a downgrade in UX experience here: we no longer have the method names in the registry
    • I don't know how to include this info, suggestions welcome. For now, we're including the MethodNum instead.
  • Handles most of the integration work needed for FIP-0034
    • We use the new v9 miner types wherever possible
    • This mostly requires handling the fact that SectorPreCommitInfo and PreCommitSectorParams are no longer the same type
    • We simply create PreCommitSectorParams from SectorPreCommitInfo wherever necessary
    • We also need to recalibrate the calculation of necessary Pre-Commit Deposit when estimating collateral needed for miners
  • Handles most of the integration work needed for FIP-0041 (by skipping it for now)
    • We do NOT start calling the new PreCommitSectorBatch2 and ProveReplicaUpdates2 methods. It isn't necessary to do so as part of this PR, and I would propose delaying calling these methods until after the nv17 upgrade.
    • See Add ProofReplicaUpgrade2 #9250 (comment).
  • Moves things around in the state interfaces to allow for better versioning of the go-state-types objects. This is expected to be a one-time refactor, not needed every time.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju jennijuju requested a review from a team as a code owner September 5, 2022 21:18
@jennijuju jennijuju marked this pull request as draft September 5, 2022 21:18
@arajasek arajasek force-pushed the jen/nv17 branch 12 times, most recently from 8583183 to 0b565eb Compare September 7, 2022 22:15
chain/actors/builtin/builtin.go Outdated Show resolved Hide resolved
chain/actors/builtin/builtin.go Outdated Show resolved Hide resolved
chain/actors/builtin/market/v9.go Outdated Show resolved Hide resolved
chain/actors/builtin/multisig/message9.go Outdated Show resolved Hide resolved
chain/actors/builtin/power/v9.go Outdated Show resolved Hide resolved
@arajasek arajasek force-pushed the jen/nv17 branch 4 times, most recently from f4fc78f to 8e94f18 Compare September 8, 2022 21:29
chain/actors/agen/main.go Show resolved Hide resolved
chain/actors/builtin/multisig/message.go.template Outdated Show resolved Hide resolved
chain/actors/builtin/registry.go Outdated Show resolved Hide resolved
@arajasek arajasek force-pushed the jen/nv17 branch 3 times, most recently from 1922ca0 to 2f7b004 Compare September 9, 2022 21:11
@arajasek arajasek force-pushed the jen/nv17 branch 4 times, most recently from 976956d to f2a8bd6 Compare September 10, 2022 16:07
@arajasek arajasek marked this pull request as ready for review September 10, 2022 16:56
@arajasek arajasek mentioned this pull request Sep 11, 2022
@arajasek arajasek linked an issue Sep 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOTUS_DISABLE for ntwk v17
3 participants