-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network: add nv17 and integrate the corresponding go state type #9267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
jen/nv17
branch
12 times, most recently
from
September 7, 2022 22:15
8583183
to
0b565eb
Compare
geoff-vball
reviewed
Sep 7, 2022
arajasek
force-pushed
the
jen/nv17
branch
4 times, most recently
from
September 8, 2022 21:29
f4fc78f
to
8e94f18
Compare
geoff-vball
reviewed
Sep 8, 2022
arajasek
force-pushed
the
jen/nv17
branch
3 times, most recently
from
September 9, 2022 21:11
1922ca0
to
2f7b004
Compare
arajasek
force-pushed
the
jen/nv17
branch
4 times, most recently
from
September 10, 2022 16:07
976956d
to
f2a8bd6
Compare
Closed
geoff-vball
approved these changes
Sep 12, 2022
5 tasks
41 tasks
5 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Towards #9246, #9248, #9249
Proposed Changes
RegistryEntry
s that satisfy the same interfaceSectorPreCommitInfo
andPreCommitSectorParams
are no longer the same typePreCommitSectorParams
fromSectorPreCommitInfo
wherever necessaryPreCommitSectorBatch2
andProveReplicaUpdates2
methods. It isn't necessary to do so as part of this PR, and I would propose delaying calling these methods until after the nv17 upgrade.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps