feat: cli: lotus info cmd #9233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds lotus info command that prints a lot of node information.
make docsgen-cli
magik6k
reviewed
Aug 30, 2022
| //Chain health calculated as percentage: amount of blocks in last finality / very healthy amount of blocks in a finality (900 epochs * 5 blocks per tipset) | ||
| health := (100 * (900 * status.ChainStatus.BlocksPerTipsetLastFinality) / (900 * 5)) | ||
| switch { | ||
| case health > 85: |
There was a problem hiding this comment.
For setting the threshold - what % do we see on mainnet?
There was a problem hiding this comment.
Its been hovering around 4.8 - 4.9 blocks on average in the last finality on mainnet while I have been monitoring it, so around 96% - 98%
Could maybe try to get some historical avarages as well for setting the threshold of what is unhealthy more realistic.
Only print address and get balance if err == nil, else print that the Default address is not set
Move newline
Put SyncBasefeeCheck in function
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
make gen happy not sad
magik6k
approved these changes
Sep 5, 2022
5 tasks
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Implements most of the metrics listed in #5766.
Proposed Changes
Add a
lotus infocommand that prints info about the lotus node:Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps