Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sealing: fix: Make DataCid resource env vars make more sense #9231

Merged
merged 4 commits into from
Aug 30, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 29, 2022

Related Issues

Fixes #9213

Proposed Changes

  • Make it possible to set resource table entries for all seal proof types with resource env-vars with no sector size
    • e.g. UNS_MAX_PARALLELISM instead of UNS_2K_MAX_PARALLELISM
    • Env-vars which include sector size will be preferred to the ones applying to all sizes
  • Scream loudly when resource env-vars with sector-size are used for DataCid/DC

NOTE: There's a bunch of noise in this PRs, likely coming from a new version of gofmt / goimports having new opinions about code comments..

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball self-requested a review August 29, 2022 14:57
@magik6k magik6k merged commit 088bf56 into master Aug 30, 2022
@magik6k magik6k deleted the fix/datacid-res-envvars branch August 30, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DC_64G_MAX_CONCURRENT=1 Environment does not have an effect.
2 participants