Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api: DataCid - ensure reader is closed #9230

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Aug 29, 2022

Related Issues

filecoin-project/boost#732

Proposed Changes

Close reader in DataCid

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@dirkmc dirkmc requested a review from a team as a code owner August 29, 2022 08:23
@dirkmc dirkmc changed the title fix: DataCid - ensure reader is closed fix: api: DataCid - ensure reader is closed Aug 29, 2022
@magik6k magik6k merged commit 78cde92 into master Aug 29, 2022
@magik6k magik6k deleted the fix/data-cid-close branch August 29, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants