Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ux: Output bytes in lotus client commP cmd #9189

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Aug 19, 2022

Related Issues

Resolves #9188

Proposed Changes

Adds an additional line that outputs bytes in the lotus client commP cmd to make it easier to add the --manual-piece-size in an offline-deal.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Adds an additional line that outputs bytes in the `lotus client commP` cmd. Resolves #9188
@rjan90 rjan90 requested a review from a team as a code owner August 19, 2022 10:29
@magik6k magik6k merged commit ea504dc into master Aug 19, 2022
@magik6k magik6k deleted the phi/commp-bytes branch August 19, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output bytes in lotus client commP cmd
2 participants