fix: ux: exclude negative available balance from spendable amount #9182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
reviewed
Aug 18, 2022
Comment on lines
+296
to
+298
| if availBalance.GreaterThan(big.Zero()) { | ||
| spendable = big.Add(spendable, availBalance) | ||
| } |
There was a problem hiding this comment.
I don't think this is the right spot to make this change. We still want to display a negative miner balance if it exists, we just don't want to add a negative miner balance to the worker balance on line 322.
There was a problem hiding this comment.
this doesnt impact the miner balance tho, like we are not changing the value of availBalance?
spendable is only printed out on line 337 - the total balance spendable
There was a problem hiding this comment.
Oh, you're right, this does work. I just hate the way this function it was originally coded - very confusing.
geoff-vball
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
resolves #9169
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps