feat: message: Add uuid to mpool message sent to chain node from miner #9174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
added 3 commits
August 16, 2022 15:56
magik6k
reviewed
Aug 16, 2022
node/modules/storageminer.go
Outdated
| return a.FullNode.MpoolPushMessage(ctx, msg, spec) | ||
| } | ||
|
|
||
| func GetUuidWrapper(a v1api.RawFullNodeAPI) v1api.FullNode { |
There was a problem hiding this comment.
Nit: would call this MakeUuidWrapper
magik6k
reviewed
Aug 17, 2022
magik6k
approved these changes
Aug 17, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#9171
Proposed Changes
Add a uuid to each message sent from the miner to the chain node in order to properly dedupe retried messages
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps