-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proving: Introduce manual sector fault recovery #9144
feat: proving: Introduce manual sector fault recovery #9144
Conversation
Jen, a real world test or an itest? Because itest is already there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!! Just a few comments. Let me know if you have any questions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for all the quick fixes! Just a few more small changes needed and we can get this merged!
Im running the latest and message still gets sent, going through the check list:
Example:
|
@Reiers How long does the command stays stuck if you don't kill it? |
@Reiers I did some quick testing and it looks like closing the channel (current version) works for me. Can you give it another try when you get a chance? |
Sure! I will test first thing tmr. |
Closing the channel did the trick - no issues. |
ffi: Revert accidental filecoin-ffi downgrade from #9144
Related Issues
#7748
Proposed Changes
Allow users to declare fault recovery manually rather than waiting for windowPost.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps