Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ci_: Run snap builds for lotus and lotus-filecoin in parallel #9133

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

ianconsolata
Copy link
Contributor

This fixes a typo in my snapcraft config that causes it to fail after publishing the first snap but before building the second:
https://app.circleci.com/pipelines/github/filecoin-project/lotus/22519/workflows/7727083f-3fdf-45da-bb2d-ca2c7ff30d37/jobs/549504

While fixing it, I also tweaked it so we can run the two snap jobs in parallel. We still need to publish under both the new lotus snap name and the legacy lotus-filecoin snap name until all our users have migrated to the lotus one.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball merged commit e24198a into master Aug 8, 2022
@geoff-vball geoff-vball deleted the ianconsolata/parallel-snap-publish branch August 8, 2022 23:48
rjan90 added a commit to filecoin-project/lotus-docs that referenced this pull request Aug 9, 2022
Changing the snapcraft repo to the new one. filecoin-project/lotus#9133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants