Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: miner cli: proving deadline command enchantments #9109

Merged
merged 9 commits into from
Aug 3, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 2, 2022

Related Issues

Merges #8721

Proposed Changes

This is #8721 with some more changes on top, mostly more detailed partition stats in the proving deadlines command to aid with debugging issues like #9103

Additional Info

Example proving deadlines output:

Deadline Index:           1
Partitions:               1
Proven Partitions:        0
Current:                  false

Partition Index:          0
	All Sectors:               2183 (bitfield - runs 77+77=154 - 2718 0s 2183 1s - 0 inv - 108 B 108B)
	Live Sectors:              2157 (bitfield - runs 56+56=112 - 2744 0s 2157 1s - 0 inv - 83 B 83B)
	Active Sectors:            2157 (bitfield - runs 56+56=112 - 2744 0s 2157 1s - 0 inv - 83 B 83B)
	Faulty Sectors:            0 (bitfield - runs 0+0=0 - 0 0s 0 1s - 0 inv - 1 B 1B)
	Recovering Sectors:        0 (bitfield - runs 0+0=0 - 0 0s 0 1s - 0 inv - 1 B 1B)
...
Partition Index:          30
	All Sectors:               2349 (bitfield - runs 1405+1405=2810 - 3435614 0s 2349 1s - 0 inv - 1.415 KiB 1449B)
	Live Sectors:              0 (bitfield - runs 0+0=0 - 0 0s 0 1s - 0 inv - 1 B 1B)
	Active Sectors:            0 (bitfield - runs 0+0=0 - 0 0s 0 1s - 0 inv - 1 B 1B)
	Faulty Sectors:            0 (bitfield - runs 0+0=0 - 0 0s 0 1s - 0 inv - 1 B 1B)
	Recovering Sectors:        0 (bitfield - runs 0+0=0 - 0 0s 0 1s - 0 inv - 1 B 1B)

...

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put the bitfield info behind a flag. It's useful debugging information, but is probably confusing to the average user calling this function. A helpful Usage message to let users know when the feature might be used would be really useful as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants