Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ci_: More tweaks to snapcraft release process #9090

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Conversation

ianconsolata
Copy link
Contributor

Related Issues

Even after merging my previous PR, snapcraft publish failed again on the 1.17.0-rc4 release with ZeroDivisionError: integer division or modulo by zero.

Proposed Changes

  1. We shouldn't be publishing to stable on RC tags, so instead publish to the candidate channel for RC releases.
  2. When I ssh in the CircleCI build environment and run the exact same publish command, it works. So the only thing I can think might be the cause is the *.snap isn't matching the built file for some reason. So add extra verbose logging to the snap deploy job to figure out why it keeps erroring.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ianconsolata ianconsolata requested a review from a team as a code owner July 27, 2022 20:35
@geoff-vball geoff-vball merged commit a843c52 into master Jul 28, 2022
@geoff-vball geoff-vball deleted the id/fix-snap-again branch July 28, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants