Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test: deflake TestQuotePriceForUnsealedRetrieval #9084

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Jul 25, 2022

Related Issues

This test failed flakily here.

The underlying issue is that the (only) miner on the network was busy sealing a sector, and so missed its PoSt. That led to it being slashed, which halts the network since the power is 0. The test eventually times out.

Proposed Changes

The bad news is that this issue affects many tests. The good news is that @ZenGround0 already has a fix, which is the BeginMiningMustPost method. We just need to use this method!

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek marked this pull request as ready for review July 27, 2022 15:14
@arajasek arajasek requested a review from a team as a code owner July 27, 2022 15:14
@geoff-vball geoff-vball merged commit b69eb08 into master Jul 27, 2022
@geoff-vball geoff-vball deleted the asr/deflake-test branch July 27, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants