Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release: v1.17.0-rc4 #9077

Merged
merged 4 commits into from
Jul 26, 2022
Merged

build: release: v1.17.0-rc4 #9077

merged 4 commits into from
Jul 26, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jul 22, 2022

Related Issues

Proposed Changes

Additional Info

A new release candidate for v1.17.0 that includes the two backported PRs #9044 and #9055

Also cherry-picks #8994, which hopefully fixes ci build.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

rjan90 added 2 commits July 22, 2022 13:09
bump version to v1.17.0-rc4
Updates CHANGELOG.md with the two new PRs 9044 and 9055
@rjan90 rjan90 requested a review from a team as a code owner July 22, 2022 11:32
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like dropping the dependency update PRs from the changelog.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #9077 (1d55066) into release/v1.17.0 (ead1e6b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.17.0    #9077      +/-   ##
===================================================
+ Coverage            40.59%   40.61%   +0.02%     
===================================================
  Files                  707      707              
  Lines                78739    78739              
===================================================
+ Hits                 31964    31980      +16     
+ Misses               41295    41282      -13     
+ Partials              5480     5477       -3     
Impacted Files Coverage Δ
build/version.go 27.27% <ø> (ø)
chain/events/state/fastapi.go 75.00% <0.00%> (-25.00%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
storage/pipeline/currentdealinfo.go 71.42% <0.00%> (-4.77%) ⬇️
chain/consensus/filcns/mine.go 64.28% <0.00%> (-2.39%) ⬇️
storage/sealer/sched_assigner_common.go 78.40% <0.00%> (-2.28%) ⬇️
storage/wdpost/wdpost_sched.go 80.00% <0.00%> (-1.91%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
chain/events/events_called.go 86.34% <0.00%> (-1.47%) ⬇️
chain/actors/builtin/miner/miner.go 46.51% <0.00%> (-1.17%) ⬇️
... and 19 more

@@ -37,7 +37,7 @@ func BuildTypeString() string {
}

// BuildVersion is the local build version
const BuildVersion = "1.17.0-rc3"
const BuildVersion = "1.17.0-rc4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this value manually set for every release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ianconsolata! Yeah, those are set for every release and then make docsgen & make docsgen-cli is run

@jennijuju jennijuju merged commit fd1207c into release/v1.17.0 Jul 26, 2022
@jennijuju jennijuju deleted the phi/v1704 branch July 26, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants