Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci:testing:remove codecov #9062

Merged
merged 2 commits into from
Jul 19, 2022
Merged

ci:testing:remove codecov #9062

merged 2 commits into from
Jul 19, 2022

Conversation

ZenGround0
Copy link
Contributor

Related Issues

Proposed Changes

It's been a good run, it doesn't appear that this is helping much. So here's an experiment to remove codecov and see if it makes our lives easier. We can always revert if we miss it.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner July 19, 2022 18:39
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we did it, glad to be undoing it.

@jennijuju
Copy link
Member

It was a good run, It did the purpose of yelling "YOU NEED A TEST" at us, and I can def see an improvement in having tests with PRs from @filecoin-project/lotus-maintainers.

Maintainers must continue requesting tests for PRs that introduce new functionality or change in behavior and only merge PR to master that has good test coverage.

Approving cuz also agree at this point it's not helping much and sometimes gives annoying ❌ that we ended up ignoring anyways (bad blocker for "enable multi-merge" or ci)

@jennijuju jennijuju merged commit 40bc05a into master Jul 19, 2022
@jennijuju jennijuju deleted the chore/delete-codecov branch July 19, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants