Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FVM: record message applied metrics #9052

Merged
merged 1 commit into from
Jul 19, 2022
Merged

fix: FVM: record message applied metrics #9052

merged 1 commit into from
Jul 19, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Jul 18, 2022

Related Issues

#9050

Proposed Changes

The stat counters that things like the CLI's "validated X messages" was missing for the FVM. This PR moves the counters themselves to the VM interface, and mutates them in the FVM as appropriate.

Note: We do NOT mutate them in the Dual execution VM / Debug VM, because the Dual Exec VM calls into the FVM::ApplyMessage(), which mutates the counter. This avoids double / triple counting.

Additional Info

Thanks @rjan90 for the nudge!

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner July 18, 2022 15:00
@arajasek arajasek changed the title FVM: record message applied metrics fix: FVM: record message applied metrics Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #9052 (279b1f4) into master (e950421) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9052      +/-   ##
==========================================
+ Coverage   40.97%   41.03%   +0.06%     
==========================================
  Files         707      707              
  Lines       78885    78887       +2     
==========================================
+ Hits        32320    32374      +54     
+ Misses      41044    41007      -37     
+ Partials     5521     5506      -15     
Impacted Files Coverage Δ
chain/vm/vm.go 58.79% <ø> (ø)
chain/vm/vmi.go 66.66% <ø> (ø)
chain/vm/fvm.go 30.23% <100.00%> (+0.40%) ⬆️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
node/hello/hello.go 69.31% <0.00%> (-6.82%) ⬇️
chain/stmgr/call.go 67.37% <0.00%> (-3.21%) ⬇️
chain/actors/builtin/power/power.go 82.60% <0.00%> (-2.18%) ⬇️
storage/sealer/sched.go 83.33% <0.00%> (-1.29%) ⬇️
chain/consensus/filcns/filecoin.go 52.27% <0.00%> (-0.44%) ⬇️
chain/stmgr/actors.go 46.34% <0.00%> (ø)
... and 19 more

@arajasek arajasek merged commit d3e5654 into master Jul 19, 2022
@arajasek arajasek deleted the asr/fvm-metrics branch July 19, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants