Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: Workaround for sealing bug #9043

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Proposed Changes

This is a fix to the sealing checks for what seems to be a compiler bug affecting ARM processors. Follow https://filecoinproject.slack.com/archives/C03F5LF3LLU/p1657814113161839 for details

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner July 15, 2022 17:52
@arajasek
Copy link
Contributor

  • Appease linter
  • Follow PR template checklist pls

@geoff-vball geoff-vball changed the title Workaround for sealing bug fix: sealing: Workaround for sealing bug Jul 15, 2022
@geoff-vball geoff-vball force-pushed the gstuart/hacky-sealing-fix branch from b3434bd to b22e24a Compare July 15, 2022 18:56
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #9043 (b22e24a) into master (e8230b5) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9043      +/-   ##
==========================================
- Coverage   40.65%   40.60%   -0.06%     
==========================================
  Files         707      707              
  Lines       78729    78731       +2     
==========================================
- Hits        32010    31968      -42     
- Misses      41253    41286      +33     
- Partials     5466     5477      +11     
Impacted Files Coverage Δ
storage/pipeline/checks.go 30.35% <50.00%> (+0.35%) ⬆️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
markets/loggers/loggers.go 91.17% <0.00%> (-8.83%) ⬇️
chain/events/events_height.go 71.42% <0.00%> (-5.05%) ⬇️
chain/events/events_called.go 86.34% <0.00%> (-3.91%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
storage/sealer/sched.go 83.33% <0.00%> (-2.57%) ⬇️
chain/consensus/filcns/mine.go 64.28% <0.00%> (-2.39%) ⬇️
storage/sealer/sched_assigner_common.go 78.40% <0.00%> (-2.28%) ⬇️
blockstore/autobatch.go 54.62% <0.00%> (-1.69%) ⬇️
... and 11 more

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harmless, and unblocks as we figure out what's going on...

@arajasek
Copy link
Contributor

This will need to be backported.

@geoff-vball geoff-vball merged commit 4b79cc6 into master Jul 18, 2022
@geoff-vball geoff-vball deleted the gstuart/hacky-sealing-fix branch July 18, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants