Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deps: update FFI to fix a slow memory leak #9042

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

Stebalien
Copy link
Member

Related Issues

filecoin-project/filecoin-ffi#307

Proposed Changes

This fixes a memory leak in creating proofs (windowed posts, and winning posts).

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

There was a memory leak in creating proofs, fixed in
filecoin-project/filecoin-ffi#308
@Stebalien Stebalien requested a review from a team as a code owner July 15, 2022 15:01
@Stebalien
Copy link
Member Author

This will work once the FFI deploy finishes.

@Stebalien
Copy link
Member Author

Thanks to @marco-storswift for finding and fix this.

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #9042 (937063c) into master (9eb8f4e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9042      +/-   ##
==========================================
- Coverage   41.07%   41.04%   -0.04%     
==========================================
  Files         707      707              
  Lines       78884    78884              
==========================================
- Hits        32404    32380      -24     
- Misses      40981    40998      +17     
- Partials     5499     5506       +7     
Impacted Files Coverage Δ
chain/exchange/peer_tracker.go 70.96% <0.00%> (-7.53%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-6.78%) ⬇️
chain/stmgr/execute.go 91.30% <0.00%> (-4.35%) ⬇️
chain/stmgr/supply.go 63.77% <0.00%> (-3.94%) ⬇️
storage/wdpost/wdpost_sched.go 78.09% <0.00%> (-3.81%) ⬇️
node/modules/services.go 58.82% <0.00%> (-2.95%) ⬇️
chain/sync.go 71.37% <0.00%> (-1.54%) ⬇️
chain/actors/builtin/market/market.go 79.26% <0.00%> (-1.22%) ⬇️
chain/vm/fvm.go 29.61% <0.00%> (-1.18%) ⬇️
chain/consensus/filcns/compute_state.go 74.26% <0.00%> (-1.17%) ⬇️
... and 22 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants