feat: storage: Path type filters #9013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9013 +/- ##
==========================================
+ Coverage 40.69% 40.74% +0.05%
==========================================
Files 707 707
Lines 78737 78875 +138
==========================================
+ Hits 32043 32139 +96
- Misses 41235 41251 +16
- Partials 5459 5485 +26
|
e842992 to
2c801b8
Compare
2c801b8 to
07dc204
Compare
magik6k
commented
Jul 12, 2022
Comment on lines
+188
to
+193
| // if api shuts down before mining, we may get an error which we should probably just ignore | ||
| // (fixing it will require rewriting most of the mining loop) | ||
| if err != nil && !strings.Contains(err.Error(), "websocket connection closed") { | ||
| require.NoError(bm.t, err) | ||
| } | ||
|
|
There was a problem hiding this comment.
review note: This isn't exactly related to this PR, but it should fix lots of test flakiness we're seeing
07dc204 to
ac2ea03
Compare
14 tasks
5 tasks
arajasek
approved these changes
Jul 14, 2022
| i.pathAlerts[si.ID] = i.alerting.AddAlertType("sector-index", "pathconf-"+string(si.ID)) | ||
| } | ||
|
|
||
| var hasConfigIsses bool |
There was a problem hiding this comment.
What is this variable name supposed to be saying?
There was a problem hiding this comment.
It tells you whether there are issues in the storage path config.
Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Implements #8794
Proposed Changes
Add two new fields to
[storagepath]/sectorstore.json:After a path with this config is attached, lotus-miner will stop putting new files of disallowed types into that path.
If there are existing files with disallowed types in a path, those files will remain readable for PoSt/Retrieval, so the worst that can happen in case of misconfiguration is that sealing tasks will get stuck waiting for storage to become available.
The most basic setup to separate sealed data from unsealed copies would be to:
"DenyTypes": ["unsealed"]to long-term sealed storage paths"AllowTypes": ["unsealed"]to long-term unsealed storage pathsHere's how storage list looks with filters set:
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps