Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update and fix libp2p #8996

Merged
merged 1 commit into from
Jul 8, 2022
Merged

chore: update and fix libp2p #8996

merged 1 commit into from
Jul 8, 2022

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Jul 8, 2022

  1. This pulls in a multistream fix that should fix that fixes a few tests (and probably a few actual bugs).
  2. This deduplicates dependencies that have been merged into the monorepo.

fixes #8953

@Stebalien Stebalien requested a review from a team as a code owner July 8, 2022 02:06
@Stebalien Stebalien requested a review from arajasek July 8, 2022 02:06
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #8996 (6bed08f) into master (d8398ed) will increase coverage by 5.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8996      +/-   ##
==========================================
+ Coverage   35.15%   40.58%   +5.43%     
==========================================
  Files         703      707       +4     
  Lines       78492    78716     +224     
==========================================
+ Hits        27592    31948    +4356     
+ Misses      45906    41294    -4612     
- Partials     4994     5474     +480     
Impacted Files Coverage Δ
node/modules/lp2p/libp2p.go 34.69% <ø> (ø)
node/modules/lp2p/transport.go 29.41% <ø> (ø)
chain/events/state/fastapi.go 75.00% <0.00%> (-25.00%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
storage/pipeline/currentdealinfo.go 76.19% <0.00%> (-2.39%) ⬇️
itests/kit/blockminer.go 69.56% <0.00%> (-1.09%) ⬇️
storage/pipeline/states_sealing.go 38.54% <0.00%> (-0.89%) ⬇️
miner/miner.go 58.03% <0.00%> (-0.33%) ⬇️
node/impl/storminer.go 23.78% <0.00%> (-0.31%) ⬇️
chain/stmgr/call.go 66.66% <0.00%> (ø)
... and 147 more

1. This pulls in a multistream fix that should fix that fixes a few
tests (and probably a few actual bugs).
2. This deduplicates dependencies that have been merged into the
monorepo.

fixes #8953
@Stebalien Stebalien force-pushed the fix/update-libp2p branch from 7492f89 to 6bed08f Compare July 8, 2022 04:39
@Stebalien Stebalien changed the title chore: update libp2p chore: update libp2p and fix Jul 8, 2022
@Stebalien Stebalien changed the title chore: update libp2p and fix chore: update and fix libp2p Jul 8, 2022
@jennijuju
Copy link
Member

jennijuju commented Jul 8, 2022

fix the thing ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proto: is printing out annoying lines for CLIs when starting
2 participants