-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recovery: Config for maximum partition count per message #8986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to somehow test this
storage/wdpost/wdpost_run_faults.go
Outdated
// respect user config if set | ||
if s.maxPartitionsPerRecoveryMessage > 0 && len(currRecoveries) >= s.maxPartitionsPerRecoveryMessage { | ||
currRecoveries = []miner.RecoveryDeclaration{} | ||
batchedRecoveryDecls = append(batchedRecoveryDecls, currRecoveries) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading this correctly, it looks like we'll include the first batch twice, and won't include the last one
14d7d04
to
628e1a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #8986 +/- ##
==========================================
+ Coverage 35.14% 40.67% +5.53%
==========================================
Files 703 708 +5
Lines 78488 78745 +257
==========================================
+ Hits 27581 32027 +4446
+ Misses 45900 41256 -4644
- Partials 5007 5462 +455
|
628e1a8
to
770c32c
Compare
Related Issues
It is possible that users might have DeclareFaultsRecovered Messages with gasused approaching the block gas limit. See msg bafy2bzacebgkmblyhe5jptkdyiaq5euk6o4w5pdgdhxfeegt4thyp4jf2svea.
Proposed Changes
#8982 , but for DeclareFaultsRecovered
We should probably just recommend users set the value to 1 if they run into this issue.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps