fix: Delegate storage auth on market nodes #8978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
Jul 7, 2022
| @@ -97,6 +98,9 @@ type StorageMinerAPI struct { | |||
| Epp gen.WinningPoStProver `optional:"true"` | |||
| DS dtypes.MetadataDS | |||
|
|
|||
| // StorageService is populated when we're not the main storage node (e.g. we're a markets node) | |||
| StorageService modules.MinerStorageService `optional:"true"` | |||
There was a problem hiding this comment.
How does this get set. I'm guessing there's DI magic but I don't see the field being set or an explicit config to initialize this which I kind of expect since its optional.
There was a problem hiding this comment.
The StorageMinerAPI struct is filled through fx.Extract, with each field being field individually thanks to the fx.In "trait" on the struct. optional tells Fx to not fail if a constructor for modules.MinerStorageService doesn't exist in the DI container - instead it leaves it not set (nil).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on market nodes all APIs are behind the market API auth, which can be backed by an API secret that's different from the one on the main lotus-miner storage node.
This is for the most part fine, but breaks if there are storage paths attached to the market node - this is because the storage subsystem assumes that all http auth is backed by the same api secret. Storage on workers just delegates auth to the main storage node to keep the api secret in one place.
This PR implements similar mechanism for lotus market nodes.
(boost may need to backport this tho I'm not sure if they support attaching storage paths)