Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix dead links to docs.filecoin.io #8966

Closed
wants to merge 5 commits into from
Closed

chore: Fix dead links to docs.filecoin.io #8966

wants to merge 5 commits into from

Conversation

TippyFlitsUK
Copy link
Contributor

@TippyFlitsUK TippyFlitsUK commented Jul 4, 2022

Related Issues

#8729

Proposed Changes

This PR updates all dead links within the Lotus repository - docs.filecoin.io to lotus.filecoin.io
Replaces #8729

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@TippyFlitsUK TippyFlitsUK requested a review from a team as a code owner July 4, 2022 13:51
@TippyFlitsUK TippyFlitsUK self-assigned this Jul 4, 2022
This was referenced Jul 4, 2022
@TippyFlitsUK TippyFlitsUK linked an issue Jul 8, 2022 that may be closed by this pull request
@TippyFlitsUK TippyFlitsUK requested a review from jennijuju July 12, 2022 14:47
@TippyFlitsUK
Copy link
Contributor Author

This still needs to be merged. Not too sure why it closed??

@TippyFlitsUK TippyFlitsUK reopened this Aug 26, 2022
@TippyFlitsUK TippyFlitsUK requested review from rjan90 and Reiers August 26, 2022 22:14
@rjan90
Copy link
Contributor

rjan90 commented Aug 29, 2022

Not sure why it closed! I think most of these changes are fine, but would love for someone with more knowledge about the changes in the yaml-files and tools to have a look, if any scripts needs to be run or similar. So probably best to let someone else review those changes :)

@TippyFlitsUK
Copy link
Contributor Author

Thanks Phi!!

@geoff-vball
Copy link
Contributor

@TippyFlitsUK This needs a make jen and then is good to merge. Sorry for letting this sit for so long!

@TippyFlitsUK
Copy link
Contributor Author

Replaced by #9301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants