Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix appimage build #8931

Merged
merged 8 commits into from
Jun 28, 2022
Merged

fix appimage build #8931

merged 8 commits into from
Jun 28, 2022

Conversation

coryschwartz
Copy link

@coryschwartz coryschwartz commented Jun 27, 2022

Related Issues

https://filecoinproject.slack.com/archives/CP50PPW2X/p1656368533715659?thread_ts=1656365814.692489&cid=CP50PPW2X

Proposed Changes

This removes lines in the Appimage.yaml file that was causing appimage not to correctly build.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@coryschwartz coryschwartz marked this pull request as ready for review June 28, 2022 07:04
@coryschwartz coryschwartz requested a review from a team as a code owner June 28, 2022 07:04
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #8931 (29b509f) into master (d1a241e) will increase coverage by 3.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8931      +/-   ##
==========================================
+ Coverage   37.70%   40.70%   +3.00%     
==========================================
  Files         765      694      -71     
  Lines       89167    76829   -12338     
==========================================
- Hits        33620    31274    -2346     
+ Misses      49839    40177    -9662     
+ Partials     5708     5378     -330     
Impacted Files Coverage Δ
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
extern/sector-storage/worker_tracked.go 80.50% <0.00%> (-9.33%) ⬇️
chain/events/observer.go 73.79% <0.00%> (-6.21%) ⬇️
api/client/client.go 57.62% <0.00%> (-4.02%) ⬇️
miner/miner.go 56.72% <0.00%> (-3.94%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.92% <0.00%> (-3.51%) ⬇️
extern/sector-storage/sched.go 83.33% <0.00%> (-2.57%) ⬇️
chain/events/events_height.go 68.90% <0.00%> (-2.53%) ⬇️
extern/sector-storage/sched_assigner_common.go 78.40% <0.00%> (-2.28%) ⬇️
blockstore/buffered.go 34.44% <0.00%> (-2.23%) ⬇️
... and 86 more

@coryschwartz coryschwartz changed the title test appimage build fix appimage build Jun 28, 2022
@coryschwartz coryschwartz merged commit cafb110 into master Jun 28, 2022
@coryschwartz coryschwartz deleted the appimage-broken-build branch June 28, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants