Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fvm: make exectraces match legacyVM some more #8889

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

arajasek
Copy link
Contributor

Related Issues

@jennijuju pointed out that the top-level message in the FVM exectrace deviates from the LegacyVM -- it uses resolved (ID) addresses, and excludes some of the information packaged in the message receipt.

Proposed Changes

Match LegacyVM behaviour by setting the top-level message & rct from the receipt itself, not the exectrace.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner June 22, 2022 15:28
@arajasek arajasek merged commit a80da7f into master Jun 22, 2022
@arajasek arajasek deleted the asr/exec-trace branch June 22, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants