Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: msig cli: Check for existing signers in add-propose #8833

Merged
merged 11 commits into from
Jul 7, 2022

Conversation

kaola526
Copy link
Contributor

@kaola526 kaola526 commented Jun 9, 2022

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@kaola526 kaola526 requested a review from a team as a code owner June 9, 2022 16:38
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Code looks clean, however there's one small issue.

cli/multisig.go Outdated Show resolved Hide resolved
@magik6k magik6k changed the title fix bug #8825 feat: msig cli: Check for existing signers in add-propose Jun 13, 2022
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with 1 nitpick.

Thanks for the PR!

cli/multisig.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #8833 (e3003dc) into master (d6e00bc) will decrease coverage by 0.04%.
The diff coverage is 36.84%.

❗ Current head e3003dc differs from pull request most recent head e278380. Consider uploading reports for the commit e278380 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8833      +/-   ##
==========================================
- Coverage   41.47%   41.43%   -0.05%     
==========================================
  Files         703      703              
  Lines       82576    82595      +19     
==========================================
- Hits        34251    34224      -27     
- Misses      42521    42558      +37     
- Partials     5804     5813       +9     
Impacted Files Coverage Δ
cli/multisig.go 13.19% <36.84%> (+0.48%) ⬆️
storage/sealer/worker_tracked.go 80.83% <0.00%> (-6.67%) ⬇️
chain/consensus/filcns/weight.go 70.58% <0.00%> (-5.89%) ⬇️
blockstore/autobatch.go 52.94% <0.00%> (-3.37%) ⬇️
chain/sub/incoming.go 59.02% <0.00%> (-2.45%) ⬇️
blockstore/buffered.go 40.00% <0.00%> (-2.23%) ⬇️
chain/actors/builtin/power/power.go 82.60% <0.00%> (-2.18%) ⬇️
chain/sync.go 70.18% <0.00%> (-1.88%) ⬇️
markets/storageadapter/client.go 40.55% <0.00%> (-1.85%) ⬇️
chain/store/store.go 62.83% <0.00%> (-1.34%) ⬇️
... and 19 more

@magik6k magik6k enabled auto-merge July 7, 2022 11:42
@magik6k magik6k merged commit 1de56d5 into filecoin-project:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants