Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error message when maxPrice is too low #8818

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

2color
Copy link
Contributor

@2color 2color commented Jun 7, 2022

During a launchpad session we tried to create a retrieval request and got an error because we didn't set the maxPrice option and it defaulted to 0.

The error message was a bit confusing and we thought it would be helpful if the error would provide an action – especially when the user doesn't know that it was set to 0 by default.

Proposed Changes

  • Improve error message

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

This also happens when maxPrice is not set and it deafults to 0
@2color 2color marked this pull request as ready for review June 7, 2022 16:28
@2color 2color requested a review from a team as a code owner June 7, 2022 16:28
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@magik6k magik6k enabled auto-merge June 9, 2022 13:32
@magik6k magik6k merged commit 16d6e0e into filecoin-project:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants