Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lotus-shed get remote peer hello message #8787

Merged
merged 8 commits into from
Jun 2, 2022
Merged

feat: lotus-shed get remote peer hello message #8787

merged 8 commits into from
Jun 2, 2022

Conversation

swift-mx
Copy link
Contributor

@swift-mx swift-mx commented Jun 2, 2022 •
edited
Loading

Related Issues

#8711

Additional Info

image

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@swift-mx swift-mx requested a review from a team as a code owner June 2, 2022 03:54
magik6k
magik6k reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

A few suggestions.

cmd/lotus-shed/hello.go Outdated Show resolved Hide resolved
cmd/lotus-shed/hello.go Outdated Show resolved Hide resolved
cmd/lotus-shed/hello.go Outdated Show resolved Hide resolved
cmd/lotus-shed/hello.go Outdated Show resolved Hide resolved
swift-mx and others added 3 commits June 2, 2022 16:36
@swift-mx @magik6k
style: libp2p new
0fd74ed 
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
@swift-mx
style: hello.go
d04594a
@swift-mx
fix: timeout 5
63a2d9f
magik6k
magik6k reviewed Jun 2, 2022
View reviewed changes
cmd/lotus-shed/hello.go Outdated Show resolved Hide resolved
swift-mx and others added 2 commits June 2, 2022 17:09
@swift-mx @magik6k
Update cmd/lotus-shed/hello.go
5a961c9 
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
@swift-mx
fix: remove say hello
9c33816
@swift-mx
Copy link
Contributor Author

swift-mx commented Jun 2, 2022

@magik6k All suggestions fix , please review again , thks

@swift-mx
Copy link
Contributor Author

swift-mx commented Jun 2, 2022

new command is : lotus-shed hello [multiaddr]
image

magik6k
magik6k reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, other than that it looks good.

cmd/lotus-shed/hello.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit 73ee595 into filecoin-project:master Jun 2, 2022
@ghost ghost mentioned this pull request Jan 21, 2024
Closed
@NateWebb03 NateWebb03 mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@travisperson travisperson travisperson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swift-mx @travisperson @magik6k