feat: only enable rcmgr by default in full nodes #8769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opt-in with envvar for other nodes, as there are still some issues with markets related protocols
|
Needs backport to nv16 branch for v1.16.0 release. |
ribasushi
reviewed
May 31, 2022
node/modules/lp2p/rcmgr.go
Outdated
| envvar := os.Getenv("LOTUS_RCMGR") | ||
| if envvar == "0" { | ||
| // this is enabled by default; specify LOTUS_RCMGR=0 to disable | ||
| if (isFullNode && envvar == "0") || // enable by default for full nodes |
There was a problem hiding this comment.
Logic seems wrong, I think it should be IGNORE, I misread the outer logic of this:
Suggested change
| if (isFullNode && envvar == "0") || // enable by default for full nodes | |
| if (isFullNode && envvar != "0") || // enable by default for full nodes |
There was a problem hiding this comment.
the branch is for disabling, logic is correct.
Maybe fix the comment?
There was a problem hiding this comment.
I retract comment, the entire if block is to do network.NullResourceManager, I am a muppet ;)
There was a problem hiding this comment.
we might want to fix the comment to avoid tripping casual reading.
Any suggestions?
ribasushi
reviewed
May 31, 2022
Co-authored-by: Peter Rabbitson <ribasushi@protocol.ai>
Co-authored-by: Peter Rabbitson <ribasushi@protocol.ai>
magik6k
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opt-in with envvar for other nodes, as there are still some issues with markets related protocols