Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build: genesis miner network version #8756

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

jennijuju
Copy link
Member

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju jennijuju requested a review from a team as a code owner May 30, 2022 17:33
@jennijuju jennijuju changed the title fix: build fix genesis miner netwokr version fix: build fix genesis miner network version May 30, 2022
@jennijuju jennijuju changed the title fix: build fix genesis miner network version fix: build: genesis miner network version May 30, 2022
@arajasek
Copy link
Contributor

What is the motivation for this? I don't disagree with the change, but the overall Genesis and Newest network versions are already messy and I don't wanna mess things up any more.

@jennijuju
Copy link
Member Author

What is the motivation for this? I don't disagree with the change, but the overall Genesis and Newest network versions are already messy and I don't wanna mess things up any more.

devnet cannot start when genesis version is lower than the newest network version

@arajasek
Copy link
Contributor

arajasek commented Jun 1, 2022

devnet cannot start when genesis version is lower than the newest network version

And so by doing this, we make sure that lotus-seed sets up things using whatever the defined GenesisNetworkVersion is? I think that makes sense.

@arajasek arajasek merged commit 05c19b3 into master Jun 7, 2022
@arajasek arajasek deleted the jen/devnetfixport branch June 7, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants