Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wdpost: Ignore faults in lotus-miner proving compute window-post #8737

Merged
merged 1 commit into from
May 27, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented May 27, 2022

Related Issues

Closes #8435

Proposed Changes

This command is generally only useful in two scenarios:

  1. Checking that some changes in proving setup are working (post worker changes, storage changes)
  2. Checking that sectors can be proven

(2) is something one would do after having sectors go faulty for whatever reason, just to check that the issue was fixed correctly - but that wasn't really possible when sectors were marked as faulty on-chain and we skipped them in what is meant to be manual provability check..

@magik6k magik6k requested a review from a team as a code owner May 27, 2022 11:21
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #8737 (af510e2) into master (7836e20) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8737      +/-   ##
==========================================
+ Coverage   40.84%   40.87%   +0.03%     
==========================================
  Files         692      692              
  Lines       76177    76179       +2     
==========================================
+ Hits        31112    31136      +24     
+ Misses      39688    39671      -17     
+ Partials     5377     5372       -5     
Impacted Files Coverage Δ
storage/wdpost_run.go 70.59% <100.00%> (+0.11%) ⬆️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/sub/incoming.go 58.10% <0.00%> (-2.45%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.96%) ⬇️
storage/wdpost_changehandler.go 98.11% <0.00%> (-0.48%) ⬇️
extern/sector-storage/stores/remote.go 57.76% <0.00%> (-0.44%) ⬇️
chain/sync.go 70.52% <0.00%> (-0.35%) ⬇️
miner/miner.go 56.39% <0.00%> (-0.33%) ⬇️
paychmgr/simple.go 83.41% <0.00%> (+0.24%) ⬆️
... and 9 more

@arajasek arajasek merged commit bcdbb72 into master May 27, 2022
@arajasek arajasek deleted the feat/compute-wdpost-no-fault branch May 27, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proving compute window-post <deadline> fails when power is lost
2 participants