Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: miner cli: sealing data-cid command #8715

Merged
merged 6 commits into from
May 24, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented May 24, 2022

Related Issues

Followup on #8557 making it possible to compute data CID on workers with lotus-miner CLI

Proposed Changes

  • Add a lotus-miner sealing data-cid command.
  • Add support for passing http readers as just urls over jsonrpc
  • Handle padding automatically on the worker side in DataCid

@magik6k magik6k requested a review from a team as a code owner May 24, 2022 13:11
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #8715 (b53db68) into master (4b1bfa9) will decrease coverage by 0.10%.
The diff coverage is 7.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8715      +/-   ##
==========================================
- Coverage   40.92%   40.82%   -0.11%     
==========================================
  Files         687      688       +1     
  Lines       75971    76047      +76     
==========================================
- Hits        31090    31045      -45     
- Misses      39523    39648     +125     
+ Partials     5358     5354       -4     
Impacted Files Coverage Δ
cmd/lotus-miner/sealing.go 37.13% <0.00%> (-9.93%) ⬇️
lib/httpreader/httpreader.go 0.00% <0.00%> (ø)
lib/rpcenc/reader.go 70.14% <33.33%> (-2.19%) ⬇️
extern/sector-storage/ffiwrapper/sealer_cgo.go 60.80% <100.00%> (+0.49%) ⬆️
itests/kit/blockminer.go 70.65% <0.00%> (-19.03%) ⬇️
cli/util.go 70.83% <0.00%> (-8.34%) ⬇️
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/stmgr/call.go 69.18% <0.00%> (-3.25%) ⬇️
... and 16 more

@magik6k magik6k merged commit 6f2c8d6 into master May 24, 2022
@magik6k magik6k deleted the feat/miner-commp-cmd branch May 24, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants